Tag: reviews

A code review checklist

Goals I’d like to do two things in this post: describe how i typically approach code reviews, and provide a basic checklist of what I think code reviews should take into consideration. My approach to code reviews If the pull request (PR) is small enough, i’ll generally review the complete diff at once (rather than by individual commit). Without a hard and fast rule, i find that something like ~200 lines affected is generally my cutoff.

Read more...